Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qwen2vl and mllama test to pass failing tests #571

Merged
merged 9 commits into from
Feb 20, 2025
Merged

Conversation

shivam15s
Copy link
Collaborator

@shivam15s shivam15s commented Feb 20, 2025

Summary

  1. Fix Qwen2VL mrope tests. Transformers removed BC with Qwen2VLRotaryEmbedding which is why we need this change
  2. Fix mllama tests to not use cross entropy. Using Cross Entropy causes logits mismatch which is expected as we do inplace operation in cross entropy kernel.
  3. Runs make checkstyle --- there seems to be a bug in checkstyle workflow where unformatted checkstyle seems to pass tests. Changed the makefile to throw error in such cases.

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@shivam15s shivam15s changed the title fix qwen tests fix qwen2vl and mllama test to pass failing tests Feb 20, 2025
Copy link
Collaborator

@momochen momochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shivam15s shivam15s merged commit bb84c0d into main Feb 20, 2025
6 of 7 checks passed
@shivam15s shivam15s deleted the shisahni/fix_qwen branch February 20, 2025 19:54
@Tcc0403 Tcc0403 mentioned this pull request Feb 21, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants