Only load zookeeper coordinator when required #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As zookeeper is only required when making use of notifiers we can exclude it and reduce a service dependency if we do not have any configured.
|
Thanks for your contribution! |
This was referenced Feb 5, 2025
|
Hello @bai, |
|
@RossierFl done! |
|
Thanks a lot, that was lighting fast ! You made my day ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As zookeeper is only required when making use of notifiers we can exclude it and reduce a service dependency if we do not have any configured.
This PR takes a very simplistic approach but I couldn't see any obvious downside to keeping it simple.