-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3410 Reduce color noise and user load #3414
base: master
Are you sure you want to change the base?
TF-3410 Reduce color noise and user load #3414
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/3414. |
|
0ec5cb0
to
16e15cc
Compare
Done |
..styleTextConfirmButton(actionStyle ?? const TextStyle( | ||
fontSize: 17, | ||
height: 24 / 17, | ||
fontWeight: FontWeight.w500, | ||
color: Colors.white, | ||
)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use as the typography define in figma to make it easy to change in the future.
..styleTextConfirmButton(actionStyle ?? const TextStyle( | |
fontSize: 17, | |
height: 24 / 17, | |
fontWeight: FontWeight.w500, | |
color: Colors.white, | |
)) | |
..styleTextConfirmButton(actionStyle ?? Theme.of(context).textTheme.bodyLarge)) |

And define details of bodyLarge in TextTheme(), then use it with ThemeData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static var fallbackTextTheme = const TextTheme(
bodyLarge: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w500,
letterSpacing: -0.15,
),
bodyMedium: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w500,
letterSpacing: 0.25,
),
bodySmall: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w500,
letterSpacing: 0.4,
),
labelLarge: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w500,
letterSpacing: 0.1,
),
labelSmall: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w500,
letterSpacing: 0.5,
),
displayLarge: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w700,
),
displayMedium: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w600,
letterSpacing: 0.4,
),
displaySmall: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w600,
letterSpacing: 0.4,
),
headlineMedium: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w600,
),
headlineSmall: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w600,
letterSpacing: 0.4,
),
headlineLarge: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w600,
fontSize: 32,
),
titleLarge: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w600,
letterSpacing: -0.15,
),
titleMedium: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w500,
letterSpacing: 0.15,
),
titleSmall: TextStyle(
fontFamily: 'Inter',
fontWeight: FontWeight.w500,
letterSpacing: 0.1,
),
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
d87b9ea
to
fec267d
Compare
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Signed-off-by: dab246 <[email protected]>
Issue
#3410
Resolved
demo-web.online-video-cutter.com.mp4