Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3410 Reduce color noise and user load #3414

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jan 9, 2025

Issue

#3410

Resolved

demo-web.online-video-cutter.com.mp4

Copy link

github-actions bot commented Jan 9, 2025

This PR has been deployed to https://linagora.github.io/tmail-flutter/3414.

@hoangdat
Copy link
Member

hoangdat commented Mar 3, 2025

@dab246 dab246 force-pushed the improvement/tf-3410-reduce-color-noise-and-user-load branch from 0ec5cb0 to 16e15cc Compare March 6, 2025 05:22
@dab246 dab246 changed the base branch from master-candidate to master March 6, 2025 05:22
@dab246
Copy link
Member Author

dab246 commented Mar 6, 2025

Done

Comment on lines 211 to 216
..styleTextConfirmButton(actionStyle ?? const TextStyle(
fontSize: 17,
height: 24 / 17,
fontWeight: FontWeight.w500,
color: Colors.white,
))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use as the typography define in figma to make it easy to change in the future.

Suggested change
..styleTextConfirmButton(actionStyle ?? const TextStyle(
fontSize: 17,
height: 24 / 17,
fontWeight: FontWeight.w500,
color: Colors.white,
))
..styleTextConfirmButton(actionStyle ?? Theme.of(context).textTheme.bodyLarge))
image

And define details of bodyLarge in TextTheme(), then use it with ThemeData

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static var fallbackTextTheme = const TextTheme(
    bodyLarge: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w500,
      letterSpacing: -0.15,
    ),
    bodyMedium: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w500,
      letterSpacing: 0.25,
    ),
    bodySmall: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w500,
      letterSpacing: 0.4,
    ),
    labelLarge: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w500,
      letterSpacing: 0.1,
    ),
    labelSmall: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w500,
      letterSpacing: 0.5,
    ),
    displayLarge: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w700,
    ),
    displayMedium: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w600,
      letterSpacing: 0.4,
    ),
    displaySmall: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w600,
      letterSpacing: 0.4,
    ),
    headlineMedium: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w600,
    ),
    headlineSmall: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w600,
      letterSpacing: 0.4,
    ),
    headlineLarge: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w600,
      fontSize: 32,
    ),
    titleLarge: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w600,
      letterSpacing: -0.15,
    ),
    titleMedium: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w500,
      letterSpacing: 0.15,
    ),
    titleSmall: TextStyle(
      fontFamily: 'Inter',
      fontWeight: FontWeight.w500,
      letterSpacing: 0.1,
    ),
  );

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@dab246 dab246 force-pushed the improvement/tf-3410-reduce-color-noise-and-user-load branch from d87b9ea to fec267d Compare March 10, 2025 02:45
@dab246 dab246 requested a review from hoangdat March 10, 2025 03:04
@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • list email item in ThreadView was not applied correct font
    image
Screenshot 2025-03-12 at 10 42 25

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • wrong font size, it must be Body/Body2
    image

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • should be M3/body/medium2 size 14, weight 600

image

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • color of next/previous button should be gray...
    Screenshot 2025-03-12 at 10 58 03

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • should be 50x50
    image

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • should be Heading/Heading small
  • apply new design for these components too

image

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • should be Body/ body 1

image

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • should use Heading/Heading small

image

@hoangdat
Copy link
Member

hoangdat commented Mar 12, 2025

  • size 17, weight 500

image

@dab246
Copy link
Member Author

dab246 commented Mar 12, 2025

  • list email item in ThreadView was not applied correct font

  • wrong font size, it must be Body/Body2

  • should be M3/body/medium2 size 14, weight 600

  • color of next/previous button should be gray...

Fixed

  • should be 50x50

What you see is Align. Its size is exactly 50px

Screenshot 2025-03-12 at 14 34 02
  • should be Heading/Heading small

  • apply new design for these components too

  • should be Body/ body 1

  • should use Heading/Heading small

  • size 17, weight 500

Fixed.

@dab246 dab246 requested a review from tddang-linagora March 12, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants