Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-PART-3] TF-2431 Implement multiple account on mobile #2435

Open
wants to merge 17 commits into
base: starting-page
Choose a base branch
from
Open

[MA-PART-3] TF-2431 Implement multiple account on mobile #2435

wants to merge 17 commits into from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jan 8, 2024 •
edited
Loading

Issue

#2431

DoD

  • Show bottom sheet dialog list account
  • Switch between active accounts
  • Logout current active account

Demo

  • Add and switch active account:
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-01-08.at.19.41.13.mp4
  • Logout current active account:
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-01-09.at.19.50.43.mp4

@dab246 dab246 requested a review from hoangdat January 8, 2024 12:44
@dab246 dab246 requested a review from hieutbui January 8, 2024 12:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/2435.

@dab246 dab246 force-pushed the feature/tf-2421-apply-new-desgin-top-menu-on-mobile branch from 96f5e0d to 27d83d6 Compare January 9, 2024 07:12
@dab246 dab246 force-pushed the feature/tf-2431-implement-multiple-account-on-mobile branch from 2dbf5aa to 658e836 Compare January 9, 2024 07:29
@dab246 dab246 force-pushed the feature/tf-2421-apply-new-desgin-top-menu-on-mobile branch from 27d83d6 to ff39d9f Compare January 15, 2024 05:34
@dab246
TF-2431 Add get all account interactor
69a675d 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Handle open multiple account picker
1d70c77 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Navigate to Setting View from multiple account picker
3bfc2ef 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Navigate to TwakeIdView when click AddAnotherAccount button
e56111c 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Reload new data when add another account success
5dedb81 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Handle switch active account
9e9720e 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Update correct format TupleKey(AccountId|UserName|..) to stor…
046c826 
…e data to hive database

Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Handle logout current active account
5b7f8a0 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Select new active account in account picker after logout success
bea937c 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Always return network Mailbox/Emails data when cache error
7e1500c 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2431 Handle add other account after logout current account success
404d910 
Signed-off-by: dab246 <[email protected]>
@dab246 dab246 changed the base branch from feature/tf-2421-apply-new-desgin-top-menu-on-mobile to starting-page January 15, 2024 05:43
@dab246 dab246 force-pushed the feature/tf-2431-implement-multiple-account-on-mobile branch from 52f3e30 to 404d910 Compare January 15, 2024 05:43
@hoangdat
Copy link
Member

please also test with the case with logout

  • acc 1 (OIDC) - acc 2 (basic auth)
  • acc 1(basic auth) - acc 2 (OIDC)
  • acc 1 - acc 2 (OIDC)

@dab246 dab246 force-pushed the feature/tf-2431-implement-multiple-account-on-mobile branch from f5aab19 to a422ef4 Compare January 16, 2024 11:01
@dab246
Copy link
Member Author

dab246 commented Jan 16, 2024

please also test with the case with logout

  • acc 1 (OIDC) - acc 2 (basic auth)
  • acc 1(basic auth) - acc 2 (OIDC)
  • acc 1 - acc 2 (OIDC)
  1. Acc 1 (OIDC) - acc 2 (basic auth)
demo1.mp4
  1. Acc 1(basic auth) - acc 2 (OIDC)
demo2.mp4
  1. Acc 1 - acc 2 (OIDC)
demo3.mp4

@dab246 dab246 requested a review from hoangdat January 16, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieutbui hieutbui Awaiting requested review from hieutbui

@hoangdat hoangdat Awaiting requested review from hoangdat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
multi-account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dab246 @hoangdat