Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint to v2 #3330

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Mar 10, 2025

golangci-lint upgrades to v2 and the configuration changed a lot.

This PR adapts .golangci.yml to v2 schema according to the Migration Guide.

@alexandear alexandear force-pushed the migrate-golangci-v2 branch 3 times, most recently from 0459e66 to 0d46a39 Compare March 10, 2025 13:45
@alexandear alexandear force-pushed the migrate-golangci-v2 branch from 0d46a39 to 2a2fdae Compare March 24, 2025 14:08
@alexandear alexandear marked this pull request as ready for review March 24, 2025 14:10
@alexandear alexandear changed the title Upgrade golangci-lint config to v2 Upgrade golangci-lint to v2 Mar 24, 2025
@alexandear alexandear force-pushed the migrate-golangci-v2 branch from 2a2fdae to 1bf3e3c Compare March 24, 2025 14:22
Signed-off-by: Oleksandr Redko <[email protected]>
@alexandear alexandear force-pushed the migrate-golangci-v2 branch from 1bf3e3c to cad433e Compare March 24, 2025 21:35
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit c37ef91 into lima-vm:master Mar 25, 2025
31 checks passed
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Mar 25, 2025
@alexandear alexandear deleted the migrate-golangci-v2 branch March 25, 2025 07:03
@@ -39,10 +39,10 @@ jobs:
- name: Verify generated files
run: make install-tools generate check-generated
- name: Run golangci-lint
uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2
uses: golangci/golangci-lint-action@dec74fa03096ff515422f71d18d41307cacde373 # v7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants