-
Notifications
You must be signed in to change notification settings - Fork 478
refactor: remove abortable-iterator usage #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closing in favor of following this proposal: #1793 |
This should be reopened since we decided against using web streams |
I created a new issue to address this @wemeetagain |
7a1104f
to
bbb0742
Compare
I wonder whether a const abortTimeout = setTimout(()=>abort(), someTimeout);
// if thing performed did complete succesfully
clearTimeout(abortTimeout) if success approach would be cleaner if you just want to abort stuff that has not succeeded in a specific timeout. This is much clearer also than adding and removing functions from an EventEmitter AbortSignal |
We had something similar to this previously via timeout-abort-controller but ultimately we switched it out because There's a non-zero cost associated with spawning loads of |
Closes #2001
Closes #2004
Closes #2020