Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable nodejs gc metrics #140

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: enable nodejs gc metrics #140

wants to merge 3 commits into from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 17, 2024 •
edited
Loading

Title

feat: enable nodejs gc metrics

Description

Adds dependency on https://github.com/SimenB/node-prometheus-gc-stats and enables the collection of nodejs garbage collection metrics.

Fixes #138

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@SgtPooki SgtPooki linked an issue Sep 17, 2024 that may be closed by this pull request
add nodejs metrics #138
Open
SgtPooki
SgtPooki commented Sep 18, 2024
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

SgtPooki
SgtPooki commented Sep 19, 2024
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@wemeetagain
Copy link
Member

Side note:
gcStats returns a timer id that can be cleared with clearInterval. Since the app assumes restart will be controlled from starting/stopping the process, we're not handling shutdown/restart of the node and metrics server, etc.
Just worth noting in case we decide to eg expose the bootstrapper with a js api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add nodejs metrics
2 participants
@SgtPooki @wemeetagain