Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossipsub v2.0 #587

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Gossipsub v2.0 #587

wants to merge 4 commits into from

Conversation

ppopth
Copy link
Contributor

@ppopth ppopth commented Dec 17, 2024

The gossipsub v2.0 is defined in the spec here libp2p/specs#653.

I made this PR as a draft first because the spec is still a draft and to get some visibility.

I need to implement this early even if the spec is still in an early stage because I have to use it to do simulations.

  • Handling receiving messages and send out IANNOUNCE
  • Adding test cases for sending out IANNOUNCE
  • Handling IANNOUNCE and send out INEED
  • Adding test cases for handling IANNOUNCE and sending out INEED
  • Handling INEED and sending out the message
  • Adding test cases for handling INEED

Optional:

  • Adding WithIgnoreIneed option to make it easier to create a malicious node that never replies to INEED

@ppopth ppopth force-pushed the gossipsub-v2 branch 3 times, most recently from 5ad493b to 409123d Compare December 23, 2024 17:26
@ppopth ppopth force-pushed the gossipsub-v2 branch 2 times, most recently from 15f7814 to 0e48aa7 Compare January 19, 2025 00:31
@ppopth ppopth marked this pull request as ready for review January 19, 2025 00:32
@ppopth
Copy link
Contributor Author

ppopth commented Jan 19, 2025

I'm not sure if WithIgnoreIneed should be added to the upstream repo, but I will implement it in my local repo anyway because I need it for my simulations in malicious cases.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know when you think it is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants