Incorporate ELF symbols of unknown type in symbolization #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symbolize_kernel_system_vmlinux test flagged another case of symbols that we may want to handle better: some ELF symbols have type NOTYPE, which according to the specification means "The symbol's type is not defined". So far we have outright excluded these symbols from symbolization, but it seems better to include them, as they could refer to either variables or functions (or, potentially anything else there is...). Presumably they refer to unannotated definitions made directly in assembly. An example is: ``` 63755: ffffffff81601120 117 NOTYPE GLOBAL DEFAULT 1 entry_SYSENTER_compat ``` With this change we make sure to include these symbols when parsing symbol tables and report them when asking for both functions and variables. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/elf-notype
branch
3 times, most recently
from
a9eff64 to
ab38e59
Compare
d-e-s-o
force-pushed
the
topic/elf-notype
branch
2 times, most recently
from
651354c to
1a547a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbolize_kernel_system_vmlinux test flagged another case of symbols that we may want to handle better: some ELF symbols have type NOTYPE, which according to the specification means "The symbol's type is not defined". So far we have outright excluded these symbols from symbolization, but it seems better to include them, as they could refer to either variables or functions (or, potentially anything else there is...). Presumably they refer to unannotated definitions made directly in assembly. An example is:
With this change we make sure to include these symbols when parsing symbol tables and report them when asking for both functions and variables.