Fix: Subscription page button

[emarc99]

• Closes: Subscription page button fix #1134
• Fixes the issues by enabling scrolling to the button.

Summary by CodeRabbit

• Documentation
  • Improved formatting and organization in our documentation for clearer guidance and consistency.
• Style
  • Enhanced spacing and layout on larger screens and subscription pages for a more refined visual experience.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 24, 2025 7:08am

[vercel]

@emarc99 is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

This pull request makes non-functional updates across several parts of the codebase. The README has been reformatted for consistent spacing and a corrected wallet list. In the useNeedAllowances hook, the calldata array now uses nullish coalescing to ensure fallback values are provided. Additionally, CSS changes adjust vertical spacing in the search container and update the subscription page styling by introducing a new CSS class and modifying container margins in both the subscription page component and its associated stylesheet.

Changes

File(s)	Change Summary
README.md	Reformatted section headers and adjusted spacing in the wallet list with minor content modifications.
hooks/useNeedAllowances.tsx	Updated the calldata array to use the nullish coalescing operator, ensuring fallback values default to "0x0".
pages/subscription.tsx, styles/.../registerV2.module.css	Modified the subscription page to include an additional CSS class and updated container margins and spacing for improved layout.
styles/search.module.css	Added a new padding-bottom: 10px; property to the .container class within a media query for screens wider than 1300px.

Assessment against linked issues

Objective	Addressed	Explanation
Subscription page button fix (#1134)	✅

Suggested labels

🔥 Ready for review

Suggested reviewers

• Marchand-Nicolas

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a09ed5 and 8be5419.

📒 Files selected for processing (2)

• pages/subscription.tsx (1 hunks)
• styles/components/registerV2.module.css (2 hunks)

🔇 Additional comments (4)

pages/subscription.tsx (2)

6-6: Import added for new CSS module

The new import provides additional styling for the subscription screen that will improve layout structure.

---

10-10: Applied new CSS class to improve subscription screen layout

Adding the subscriptionScreen class directly addresses the scrolling issue by enabling proper height management of the container.

styles/components/registerV2.module.css (2)

13-13: Added top margin to container

The 1rem top margin creates better vertical spacing, which improves the overall layout of the subscription page.

---

28-31: Created new subscriptionScreen class for vertical layout control

This CSS class directly addresses the PR objective of enabling scrolling to the subscription button. By setting:

• height: auto - Allows the container to expand naturally with content
• min-height: 88vh - Ensures the container takes at least 88% of viewport height

This ensures the container is tall enough to allow scrolling while still containing all elements properly.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[emarc99]

[emarc99]

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

styles/search.module.css (1)

18-18: Ensure Adequate Bottom Padding for Larger Screens
The addition of padding-bottom: 10px; in the media query for screens with a minimum width of 1300px helps provide extra spacing at the bottom of the container. Please verify on larger displays that this padding is sufficient to expose the subscription button when scrolling. Consider using relative units (like rem) for consistency in responsive design if needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 367217b and 4a09ed5.

📒 Files selected for processing (2)

• styles/Home.module.css (1 hunks)
• styles/search.module.css (1 hunks)

🔇 Additional comments (2)

styles/Home.module.css (2)

2-3: Flexible Screen Sizing with Updated Height Properties
Changing the .screen class to use min-height: 88vh; alongside height: auto; is a thoughtful adjustment. This ensures that content, including the subscription button, is not clipped and that the layout adapts to overflow (thereby enabling scrolling). Please confirm that 88vh provides adequate space across various devices.

---

9-9: Added Bottom Padding Enhances Content Accessibility
The new padding-bottom: 40px; gives extra room at the bottom of the screen. This should help ensure that the subscription button remains visible when users scroll. Make sure that this added padding does not unintentionally affect other layout elements on different screen sizes.

[Marchand-Nicolas]

You should add a 1mb margin between the header and the card.

Also, please make sure your PR doesn't break other pages. You can see the home page is broken

[Marchand-Nicolas]

LGTM well done