Fix: Add 48px margin between menu and domain list #1123

anljvnsjnfnutdfns · 2025-03-09T03:26:31Z

Summary by CodeRabbit

Style
- Refined the navigation bar’s appearance with added spacing below to improve the layout of adjacent elements.
- Added a blank line to the beginning of the identities CSS file for better readability.

vercel · 2025-03-09T03:26:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 12, 2025 4:09am

vercel · 2025-03-09T03:26:37Z

@anljvnsjnfnutdfns is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-03-09T03:26:38Z

Walkthrough

The pull request includes two styling modifications. A new blank line has been added at the beginning of styles/components/identitiesV1.module.css, which does not affect functionality. Additionally, the CSS file styles/components/navbar.module.css has been updated by adding the property margin-bottom: 3rem; to the .navbarContainer class to adjust spacing. No changes were made to exported or public entities.

Changes

File(s)	Change Summary
`styles/.../identitiesV1.module.css`	Inserted a blank line at the beginning; no functional impact
`styles/.../navbar.module.css`	Added `margin-bottom: 3rem;` to the `.navbarContainer` class, affecting the layout spacing below the navbar

Suggested labels

❌ Change request

Suggested reviewers

Marchand-Nicolas

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96b665f and 5296bc3.

📒 Files selected for processing (1)

styles/components/navbar.module.css (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

styles/components/navbar.module.css

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

styles/components/identitiesV1.module.css (1)

1-1: Extraneous Blank Line
A blank line has been added at the top of this CSS file. While this does not affect functionality or styling, you might consider removing it for consistency unless it's intentionally used for visual separation or to adhere to specific coding style guidelines.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7476936 and 375e9be.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

components/identities/skeletons/identitiesSkeleton.tsx (1 hunks)
styles/components/identitiesV1.module.css (1 hunks)

🔇 Additional comments (1)

components/identities/skeletons/identitiesSkeleton.tsx (1)

7-7: Margin Update Applied via Tailwind Class
The update to the <div> now using the "mt-12" class correctly applies a margin of 48px (3rem, assuming the base unit is 16px). This directly addresses the PR objective by adding the desired spacing between the menu and the domain list.

Marchand-Nicolas

Hey, thanks for your PR. But the bug seems to be fixed

Marchand-Nicolas · 2025-03-11T19:14:21Z

@anljvnsjnfnutdfns Kevin just confirmed me he still has the problem. He uses the Braavos app

anljvnsjnfnutdfns · 2025-03-12T02:04:08Z

@Marchand-Nicolas okay I'll work on it again

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

styles/components/navbar.module.css (1)

66-66: Margin Value Verification:
The added CSS property margin-bottom: 2rem; in the .navbarContainer class is intended to create spacing between the menu and the domain list. However, please verify that 2rem indeed corresponds to the intended 48px margin. If your base font-size is 16px, then 2rem equals 32px—which would fall short of the 48px target. Consider using 3rem (if 1rem is 16px) or confirming that the base font-size is set such that 2rem equals 48px.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 375e9be and 96b665f.

📒 Files selected for processing (1)

styles/components/navbar.module.css (1 hunks)

EDOHWARES

@anljvnsjnfnutdfns, avoid using margin-bottom for spacing. Since the navbar has position: fixed, it remains on an upper layer, causing it to shadow the domain list.

Instead, increase the margin-top of the domain list container to create the necessary spacing.

anljvnsjnfnutdfns · 2025-03-14T10:27:58Z

Okay. I will work on it

…

On Thu, 13 Mar 2025, 11:30 pm EDOHWARES, ***@***.***> wrote: ***@***.**** commented on this pull request. @anljvnsjnfnutdfns <https://github.com/anljvnsjnfnutdfns>, do not use margin bottom for the spacing(as the navbar has a position of fixed: meaning its at an upper layer, thereby causing it to shadow the domain lists). Increase the margin-top of the domain lists container instead. — Reply to this email directly, view it on GitHub <#1123 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBML6Q5QUIHOGFAVQJGWGID2UIBKFAVCNFSM6AAAAABYTYAX36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOBTGQ3DKOBXGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Marchand-Nicolas

Doesn't work

Marchand-Nicolas · 2025-03-14T14:26:43Z

components/identities/skeletons/identitiesSkeleton.tsx

@@ -4,7 +4,7 @@ import styles from "../../../styles/components/identitiesV1.module.css";

 const IdentitiesSkeleton: FunctionComponent = () => {
  return (
-    <div className="mt-12">
+    <div className="">


Do not keep empty classe names

anljvnsjnfnutdfns · 2025-03-14T16:19:44Z

@Marchand-Nicolas can you pls review the changes

Marchand-Nicolas · 2025-03-14T17:25:57Z

@Marchand-Nicolas can you pls review the changes

@anljvnsjnfnutdfns I have already reviewed it. Please check my review

Fix: Add 48px margin between menu and domain list

375e9be

coderabbitai bot reviewed Mar 9, 2025

View reviewed changes

vercel bot deployed to Preview – app-starknet-id March 9, 2025 03:28 View deployment

Marchand-Nicolas requested changes Mar 11, 2025

View reviewed changes

Marchand-Nicolas closed this Mar 11, 2025

Marchand-Nicolas reopened this Mar 11, 2025

add margin between menu and domain list

96b665f

vercel bot deployed to Preview – app-starknet-id March 12, 2025 03:50 View deployment

coderabbitai bot reviewed Mar 12, 2025

View reviewed changes

add margin between menu and domain list

5296bc3

vercel bot deployed to Preview – app-starknet-id March 12, 2025 04:09 View deployment

EDOHWARES reviewed Mar 13, 2025

View reviewed changes

Marchand-Nicolas requested changes Mar 14, 2025

View reviewed changes

Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Mar 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Add 48px margin between menu and domain list #1123

Fix: Add 48px margin between menu and domain list #1123

anljvnsjnfnutdfns commented Mar 9, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 9, 2025 •

edited

Loading

vercel bot commented Mar 9, 2025

coderabbitai bot commented Mar 9, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

Marchand-Nicolas left a comment

Marchand-Nicolas commented Mar 11, 2025

anljvnsjnfnutdfns commented Mar 12, 2025

coderabbitai bot left a comment

EDOHWARES left a comment •

edited

Loading

anljvnsjnfnutdfns commented Mar 14, 2025 via email

Marchand-Nicolas left a comment

Marchand-Nicolas Mar 14, 2025

anljvnsjnfnutdfns commented Mar 14, 2025

Marchand-Nicolas commented Mar 14, 2025

Fix: Add 48px margin between menu and domain list #1123

Are you sure you want to change the base?

Fix: Add 48px margin between menu and domain list #1123

Conversation

anljvnsjnfnutdfns commented Mar 9, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Mar 9, 2025 • edited Loading

vercel bot commented Mar 9, 2025

coderabbitai bot commented Mar 9, 2025 • edited Loading

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

Marchand-Nicolas commented Mar 11, 2025

anljvnsjnfnutdfns commented Mar 12, 2025

coderabbitai bot left a comment

Choose a reason for hiding this comment

EDOHWARES left a comment • edited Loading

Choose a reason for hiding this comment

anljvnsjnfnutdfns commented Mar 14, 2025 via email

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

Marchand-Nicolas Mar 14, 2025

Choose a reason for hiding this comment

anljvnsjnfnutdfns commented Mar 14, 2025

Marchand-Nicolas commented Mar 14, 2025

anljvnsjnfnutdfns commented Mar 9, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 9, 2025 •

edited

Loading

coderabbitai bot commented Mar 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

EDOHWARES left a comment •

edited

Loading