Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identities mobile page - Add margin #1045

Open
Tracked by #1048
Kevils opened this issue Feb 11, 2025 · 17 comments · May be fixed by #1123
Open
Tracked by #1048

Identities mobile page - Add margin #1045

Kevils opened this issue Feb 11, 2025 · 17 comments · May be fixed by #1123
Assignees
Labels
Good first issue Good for newcomers May Be Rewarded ODHack12 Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution

Comments

@Kevils
Copy link
Collaborator

Kevils commented Feb 11, 2025

Description 📹

Current :
Image

New design :
Image

Figma : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=5702-25389&t=7dznGvzbQw2r8boK-1

Add margin between menu and domain list, 48px for example

The purpose of this issue is to add a margin between the menu and the domain list on the mobile identity page of the Starknet ID platform.

Issue Details

  • Current State: There is no margin between the menu and the domain list on the mobile version.
  • Proposed State: Add a 48-pixel margin between the menu and the domain list.
  • Design: The new design is available on Figma (link provided in the issue description).

Actions to Take

  1. Fork and Branch Creation:

    • Fork the repository and create a new branch using the issue number.
  2. Implementation of Changes:

    • Add a 48-pixel margin between the menu and the domain list on the mobile page.
    • Ensure the changes integrate properly with other components.
  3. Testing and Validation:

    • Test modifications locally.
    • Verify that existing functionalities are not affected.
  4. Commit and Submission:

    • Make a commit with a clear message describing the addition of the margin.
    • Submit a pull request closing the issue.

This issue is suitable for new contributors and may be rewarded.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Kevils Kevils added Good first issue Good for newcomers Open for contribution An issue that is available for an Only Dust contribution and removed Good first issue Good for newcomers Open for contribution An issue that is available for an Only Dust contribution labels Feb 11, 2025
@Elite-tch
Copy link
Contributor

May I take this issue on?

@angeloobeta
Copy link

@Kevils I would like this task to be assigned to me, As a software engineer and active only dust contributor with experience in ReactJs (NextJs), Tailwind, Material UI and Chakra.

I have review the whole code base and the Figma design; I understand what's required.
I would love to solve this issue.

Thank you.

@Isaacprogi
Copy link
Contributor

Isaacprogi commented Feb 11, 2025

Hello can I take this task?.I'm a software engineer with 5+ years of experience with great proficiency in the react ecosystem, including next js and backend technologies.Thanks

@Nwanne-san
Copy link

Hi, my name is Nwanne, and I am a frontend developer skilled in React, Next.js, JavaScript, TypeScript, Tailwind CSS, and Shadcn. For this task, I will:

Implement a margin of certain pixels between the menu and domain list on the mobile page
Ensure it aligns with the accordingly as displayed on the figma.

I'll love to contribute to this project.
ETA: 1 hour

@viktrified
Copy link

Is it okay if I take this?

@Koda-Black
Copy link
Contributor

Adjust Margin Between Menu and Domain List

Hello Team,

Updating the layout to add margin between the menu and domain list for better spacing and visual clarity.

Changes

  • Increase spacing between the menu and domain list.
  • Ensure consistency across different screen sizes.

ETA: 30 mins

Let me know if any adjustments are needed.

Best regards,
Kingsley Onuorah

@chiscookeke11
Copy link

Can I handle this task?

@Nikhil-550
Copy link
Contributor

I am interested in being assigned to the issue. With my background in front-end development and animation integration, I am confident I can contribute effectively to enhancing the user experience through smooth and engaging themes as provided and suggested by you.

@mimisavage
Copy link

Would love to tackle this!

@tali-creator
Copy link
Contributor

Can I handle this task?

@pheobeayo
Copy link
Contributor

May I be assigned to this?

@Nashezekiel
Copy link

Can I take this from here?

@fedisaev
Copy link

Can I work on this, please?

@Kevils Kevils added Good first issue Good for newcomers ODHack12 Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution labels Mar 5, 2025
@Jayrodri088
Copy link
Contributor

Jayrodri088 commented Mar 6, 2025

I would love to take this on, my ETA is 10mins

@EDOHWARES
Copy link

HI. I'm EDOHWARES, a Software Developer.
Requirement - Adding margin between menu and domain list
I'll submit a PR withing 24hrs, if you assign me this issue.

@Marchand-Nicolas
Copy link
Collaborator

Problem already fixed

@Jayrodri088
Copy link
Contributor

I would love to handle this, my ETA is 1 hour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers May Be Rewarded ODHack12 Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.