-
-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erased routing, codegen opts #3623
Conversation
3eb3d01
to
cdc25da
Compare
This is almost finished, there's a second part that somehow breaks leptos, which I need to fix, but I've found the change that breaks it (not in here), I'll fix it then finish this in like 8 hrs |
Should be ready to go, updated description. |
Happy to say my This means (I think) the erasure journey is now complete 🎉 |
This looks good to me, I'll let @gbj take a look before we merge this. Super excited! |
There's a few things in here (sorry!), to sum up:
view!{}
macro now erases thoroughlyfn()
functions with concretefn foo
declarations rather than closures, TIL this is more codegen efficientBox<dyn Any>
in erased containers, which is more efficient and (I think) avoids a massivedyn Any
vtableIntoFragment
containsStaticVec
instead of aVec
This shouldn't have any breaking changes.