Script source(s) as function (props => sources) #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdelaorden
changed the title
|
I noticed the checks, the AppVeyor error is chinese to me and the Travis CI environments seem quite old to me (node 0.10, node 0.12 and so on), even |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature #29
Much like connect from Redux, if sources is a function then call that function with the decorated
component props to generate the final script sources to load.
Pull request includes automatic Prettier code formatting (sorry about that not intended), a new test to verify the functionality and the simple change to the container to calculate the scripts to load in the constructor.