Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glitch in completed quiz report sections displaying incorrect values #13220

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LianaHarris360
Copy link
Member

Summary

This pull request updates AttemptLogList.vue to display the correct attempt logs and correct/incorrect icon within each section.

The computed property attemptLogsBySection has been added to generate and return the attempt logs within every section.

The computed property attemptLogsForCurrentSection has been updated to use attemptLogsBySection to access the correct attempt log based on the selected section + question pair when in mobile view.

The attempt log object passed to AttemptLogItem has been updated to use attemptLogsBySection as well.

Before:

AttemptLogsBefore.mov

After:

AttemptLogsAfter.mov

References

Fixes #13101

Reviewer guidance

  1. Assign a quiz with at least 2 sections to a learner
  2. Complete the quiz by giving only correct answers in one of the sections and only incorrect answers in the other.
  3. Observe the quiz report either as a learner or a coach

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I tested locally and the correct info was shown for each section :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completed quiz report - Sections with correct and incorrect values are glitching
2 participants