Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes sync schedule update/edit string available #13207

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented Mar 13, 2025

Summary

Add the string required for 10753. Will update draft PR to include snackbar after task composable fix is merged

References

Fixes #10753

Screen.Recording.2025-03-25.at.6.25.59.PM.mov

Reviewer guidance

Add, create, and delete a sync schedule. The proper snackbar should display for each.

@marcellamaki marcellamaki added the P0 - critical Priority: Release blocker or regression label Mar 18, 2025
@marcellamaki marcellamaki force-pushed the add-sync-schedule-updated-string branch from 040cfdc to 4cfeef7 Compare March 25, 2025 22:25
@marcellamaki marcellamaki force-pushed the add-sync-schedule-updated-string branch from 4cfeef7 to a95a8f1 Compare March 25, 2025 22:31
@marcellamaki marcellamaki marked this pull request as ready for review March 25, 2025 22:31
@marcellamaki marcellamaki requested a review from pcenov March 25, 2025 22:33
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the correct snackbar is displayed on adding, creating, and deleting a sync schedule.

Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcellamaki marcellamaki merged commit ecb6740 into learningequality:develop Mar 26, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new message when schedule sync task is updated.
4 participants