Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13168 create composable for exam report data fetching for learn exam report viewer #13203

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

a-s-t-e-y-a
Copy link

Summary

After adding the composable in the exam view report, the same functionality is achieved.

Kolibri.mp4

Manual Test Cases Run:

  • After running <pre-commit run --all-files>:
    250313_15h25m05s_screenshot
  • After running <yarn run test>:
    250313_14h23m51s_screenshot

References

Reviewer Guidance

@LianaHarris360 Kindly review my PR. If there are any improvements, I'm happy to hear them and willing to make changes.

This is my first contribution to Kolibri, so I apologize if I've done anything incorrectly.

a-s-t-e-y-a and others added 3 commits March 13, 2025 11:25
…reate-composable-for-exam-report-data-fetching-for-LearnExamReportViewer
- Remove examReportViewer module and also make changes to the pluginModule.js
- refactor the classesRoutes.js which is previously using vuex state
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Mar 13, 2025
@MisRob MisRob requested a review from nucleogenesis March 17, 2025 09:42
@MisRob MisRob added the TODO: needs review Waiting for review label Mar 17, 2025
@MisRob
Copy link
Member

MisRob commented Mar 17, 2025

Thanks @a-s-t-e-y-a! We will review in the upcoming weeks. I wanted to note that review waiting times are still longer.

@LianaHarris360 LianaHarris360 self-requested a review March 17, 2025 15:04
@a-s-t-e-y-a
Copy link
Author

@LianaHarris360 @MisRob Thank you so much for this. I apologize again for tagging everyone, as I didn't know it would take time. I'm ready to make any necessary changes that you may ask for.

@MisRob
Copy link
Member

MisRob commented Mar 17, 2025

No problem @a-s-t-e-y-a, you didn't do anything bad. Part of my role is a bit of moderation when needed so future collaboration can be happy for everyone, that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants