#13168 create composable for exam report data fetching for learn exam report viewer #13203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for LearningExamReportViewer
…reate-composable-for-exam-report-data-fetching-for-LearnExamReportViewer
- Remove examReportViewer module and also make changes to the pluginModule.js - refactor the classesRoutes.js which is previously using vuex state
github-actions
bot
added
APP: Learn
|
Thanks @a-s-t-e-y-a! We will review in the upcoming weeks. I wanted to note that review waiting times are still longer. |
|
@LianaHarris360 @MisRob Thank you so much for this. I apologize again for tagging everyone, as I didn't know it would take time. I'm ready to make any necessary changes that you may ask for. |
|
No problem @a-s-t-e-y-a, you didn't do anything bad. Part of my role is a bit of moderation when needed so future collaboration can be happy for everyone, that's all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After adding the composable in the exam view report, the same functionality is achieved.
Kolibri.mp4
Manual Test Cases Run:
<pre-commit run --all-files>:<yarn run test>:…
References
kolibri/plugins/learn/assets/src/composables/useExamReport.jskolibri/plugins/learn/assets/src/views/LearnExamReportViewer.vue…
Reviewer Guidance
@LianaHarris360 Kindly review my PR. If there are any improvements, I'm happy to hear them and willing to make changes.
This is my first contribution to Kolibri, so I apologize if I've done anything incorrectly.
…