[DO NOT MERGE] QA for KDS #900 Fixes keyboard navigation in Ktable #13201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Build Artifacts
|
|
The test failure doesn't seem to be related |
|
Tested with NVDA on Windows 10, and I can confirm that KDS issue learningequality/kolibri-design-system#883 is indeed fixed. 👏🏽 🙏🏽 No keyboard navigation issues or regressions per se on the Facility > Users KTable, but one thing is missing: making the ℹ️ icon in the third column focusable (maybe even a button), with the 
This is not in the scope of the present PR, so I will open a separate issue. |
|
Thank you, @radinamatic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
QA PR for learningequality/kolibri-design-system#900 that contains couple of bugfixes and maintenance internal refactor of
KTable.@radinamatic would you please
(1) confirm that KDS #883 is fixed
(2) test /facility/#/users
KTablefor any regressions, particularly a11y