-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add powershell fallback for windows disk information. #13186
base: develop
Are you sure you want to change the base?
Add powershell fallback for windows disk information. #13186
Conversation
Build Artifacts
|
02b6c84
to
00669fb
Compare
Working a little too well! |
00669fb
to
f5dea18
Compare
Hi @pcenov I checked with @radinamatic and also tested on my own Windows 10 device, and it seems like this is how it is for Windows 10 as well. I have made a slight tweak to ensure we have better naming for drives that are unnamed. If we can test this on Windows 11 and Windows 10 just to double check these changes, that would be great! |
Improve drive naming.
f5dea18
to
3626591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rtibbles - yes, I confirm that this is working correctly now in both Win 11 and 10:
Summary
References
Fixes #13175
Reviewer guidance
Opening as a draft as I have no good way to test this locally.