Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add powershell fallback for windows disk information. #13186

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add powershell fallback for windows disk information. #13186

wants to merge 1 commit into from

Conversation

rtibbles
Copy link
Member

Summary

  • Adds a powershell fallback when wmic is no longer available

References

Fixes #13175

Reviewer guidance

Opening as a draft as I have no good way to test this locally.

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Mar 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0a3.dev0_git.74.gaee0b998.pex
Windows Installer (EXE) kolibri-0.18.0a3.dev0+git.74.gaee0b998-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0a3.dev0+git.74.gaee0b998-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0a3.dev0+git.74.gaee0b998.dmg
Android Package (APK) kolibri-0.18.0a3.dev0+git.74.gaee0b998-0.1.4-debug.apk
Raspberry Pi Image kolibri-pi-image-0.18.0a3.dev0+git.74.gaee0b998.zip
TAR file kolibri-0.18.0a3.dev0+git.74.gaee0b998.tar.gz
WHL file kolibri-0.18.0a3.dev0+git.74.gaee0b998-py2.py3-none-any.whl

@rtibbles rtibbles force-pushed the by_the_power_of_windows11_shell branch 4 times, most recently from 02b6c84 to 00669fb Compare March 12, 2025 01:21
@pcenov
Copy link
Member

pcenov commented Mar 12, 2025

Hi @rtibbles I confirm that now the export is working fine in Windows 11.

In fact now I am even seeing my C and D drives (C is not named, D is called Media) listed among the usb and sdcard drives:

no-label-drive

Logs: logs.zip

@rtibbles
Copy link
Member Author

Working a little too well!

@rtibbles rtibbles force-pushed the by_the_power_of_windows11_shell branch from 00669fb to f5dea18 Compare March 12, 2025 19:49
@rtibbles
Copy link
Member Author

Hi @pcenov I checked with @radinamatic and also tested on my own Windows 10 device, and it seems like this is how it is for Windows 10 as well. I have made a slight tweak to ensure we have better naming for drives that are unnamed. If we can test this on Windows 11 and Windows 10 just to double check these changes, that would be great!

@rtibbles rtibbles marked this pull request as ready for review March 12, 2025 19:50
@rtibbles rtibbles force-pushed the by_the_power_of_windows11_shell branch from f5dea18 to 3626591 Compare March 12, 2025 23:37
@pcenov pcenov self-requested a review March 13, 2025 12:34
pcenov
pcenov approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtibbles - yes, I confirm that this is working correctly now in both Win 11 and 10:

drive name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcenov pcenov pcenov approved these changes

Assignees
No one assigned
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Milestone
Kolibri 0.18: General maintenance
Development

Successfully merging this pull request may close these issues.

Disk enumeration fails on Windows 11
2 participants
@rtibbles @pcenov