Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no resources available" instead of the available libraries #13184

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Mar 11, 2025

Summary

Fixes the showing of "No resources available" instead of the available other libraries.

Before

image

After

Library0.17.5.mp4

closes #13071

References

#13071

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Mar 11, 2025
@LianaHarris360
Copy link
Member

Tagging @radinamatic @pcenov for QA review

@radinamatic
Copy link
Member

Assets from this PR were tested on both Ubuntu and Windows 11, and the originally reported issue is indeed corrected.

learn-library

However, in the scenario that we were discussing on Slack with @rtibbles, when there are no resources in the library and no peers in the local network:

  • admin would (eventually) see the channels on Kolibri Studio (as in the screenshot), but
  • non-admin users would see a rather empty page, which is not ideal

For that reason @rtibbles suggested we would want that page to be more dynamic based on whether there are local libraries available, and preserve the messaging from the content unavailable page for the empty state.

So the idea is for the non-admin users to keep the current change from this PR IF there are other peers in the local network (and something does appear under the Other libraries). And in case there are no other peers around, and the class server has no channels, display the No resources available heading and Ask your coach or administrator for assistance below.

cc @marcellamaki @jtamiace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Learn > Library - Seeing "No resources available" instead of the available libraries
3 participants