Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all jobs to avoid ubuntu-20.04 image removal #13163

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Mar 6, 2025

Summary

  • Updates all ubuntu-20.04 images to ubuntu-latest.
  • Puts all EOL Python jobs into docker containers with the appropriate Python installed
  • Adds an environment variable to skip using the C extensions installed in the wheel
  • Removes our C extension and no-c-extension tests in favour of doing a smoke test of the built whl file (with and without the above environment variable)
  • Updates the content directory sanity check test to use a file path that is unwriteable even for root

References

Fixes the Kolibri part of learningequality/kolibri-ecosystem#41

Reviewer guidance

Does everything still pass?

Note that this changes the names of our Python tests, and deletes the C and no C extension tests, so some of our required tests now have different names - these will need to be updated after this is merged (with a required check bypass).

@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Mar 6, 2025
@rtibbles rtibbles marked this pull request as draft March 6, 2025 15:49
@rtibbles rtibbles force-pushed the ubuntu_image branch 3 times, most recently from e1ef985 to ad8d17a Compare March 6, 2025 22:26
@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Mar 6, 2025
@rtibbles rtibbles force-pushed the ubuntu_image branch 4 times, most recently from c35df29 to caa0fe7 Compare March 6, 2025 23:32
Containerize all workflows that need EOL Python versions.
Replace cextension smoke tests with a whl file test.
@rtibbles rtibbles marked this pull request as ready for review March 7, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants