-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement task polling composable #13158
base: develop
Are you sure you want to change the base?
Implement task polling composable #13158
Conversation
Build Artifacts
|
fa463dd
to
ad671c0
Compare
ad671c0
to
be6a9ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing any concerns with the implementation, but it has fallen a little short of the issue - at the very least I would have expected to see the task polling that is happening here: https://github.com/learningequality/kolibri/blob/develop/packages/kolibri-common/components/SyncSchedule/ManageSyncSchedule.vue to be replaced by this composable too (as switching between this component and the edited Edit component were the main causes of the bug).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking as I'd expect - @pcenov @radinamatic if you could check the sync scheduling workflows on this, and ensure we're not seeing any regressions in viewing, creating, updating scheduled syncs, that would be great.
Hi @ozer550 the only regression I am observing is that if after having added a sync schedule I click the "Edit" button, then I'm not seeing the correct value in the "Frequency" drop-down and there are errors in the console. If I click "Cancel" and then click "Edit" again, then I am seeing the correct value: frequency.mp4 |
Hi @pcenov! I am unable to reproduce this. regression.mp4 |
Hi @ozer550 - could you try it out by creating a sync schedule for an actual device, not KDP? |
Summary
Before:
Compartir.pantalla.-.2025-03-10.16_10_18.mp4
After:
Compartir.pantalla.-.2025-03-10.16_13_51.mp4
References
Closes #13093
Reviewer guidance