-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create composable for Exam Report Data Fetching for LearnExamReportViewer #13168
Comments
@LianaHarris360 I hope this message finds you well Proposal: Create Composable for Exam Report Data Fetching in LearnExamReportViewerIssue: #13168 Problem StatementThe current implementation of Right now the LearnExamReportViewer getting its data primarily from Vuex state Proposed SolutionCreate a dedicated composable
|
Hi @a-s-t-e-y-a thanks for volunteering to address this issue! It is currently blocked by an open pull request, I've updated the issue write-up to reflect this. It will be ready to be worked on once that PR is approved and merged. |
@LianaHarris360 Thanks for the update! I'll keep an eye on the PR and get started once it's merged. Let me know if there’s anything else I can do in the meantime |
Hi @LianaHarris360 , Can I work on this one ? |
Someone has already asked to work on this issue and now that the blocking PR has been resolved, I will assign @a-s-t-e-y-a |
@LianaHarris360 I'll start working on this |
I'd love to take on this issue! Please assign it to me, and I'll share the outcome in a few days. |
Hi, would love to take on this issue in future if needed... also willing to help @a-s-t-e-y-a in solving this. |
This issue has already been assigned to someone, and it will only be re-assigned if the current person says they cannot complete it. We greatly appreciate the offers to contribute, but please avoid volunteering for tasks that have already been assigned to others. |
… for LearningExamReportViewer
…reate-composable-for-exam-report-data-fetching-for-LearnExamReportViewer
@LianaHarris360 can you please review my PR |
Thanks for your work @a-s-t-e-y-a. One of us will review in the upcoming weeks. I will choose a reviewer later depending on the team's bandwith. I'd like to ask you to be thoughtful about using mentions as each of them sends a notification to team members, some of them are not even involved in this work. Please have patience. |
Thank you for your message and guidance. I’ll be more mindful with mentions to avoid unnecessary notifications. I’m happy to wait patiently for the next steps and will assist whenever the team is ready. Please let me know if there’s anything else I can do in the meantime. |
Thanks for your understanding @a-s-t-e-y-a |
The current data fetching implementation of LearnExamReportViewer relies on Vuex state and indirectly on the HomePage’s initialization of activeClassesQuizzes.
To reduce technical debt and improve the reliability of the exam report flow, the exam report data fetching should be moved into a dedicated composable that exposes a clear API for fetching and managing exam report data.
State: https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/learn/assets/src/modules/examReportViewer/index.js#L7
Handlers:
https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/learn/assets/src/modules/examReportViewer/handlers.js
These should be replaced by a new composable created in kolibri/plugins/learn/assets/src/composables and all references to the state and handlers should go through the composable instead.
The text was updated successfully, but these errors were encountered: