-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: reduce elaboration time and proof size of tree map internals #7459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathlib CI status (docs):
|
TwoFX
reviewed
Mar 13, 2025
TwoFX
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-no
Do not include this PR in the release changelog
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several things done here:
simp_to_model
which already exists in hash maps. This version ofsimp_to_model
allows specifying the query operations to use in addition to the modifying operations. This is mostly to improve elaboration time and actually increases olean size.toListModel_balance
directly, we writetoListModel_balanceₘ
and use that instead (this saves ~3 MB).fun_cases
anddsimp
instead ofrw [x.eq_def]
more frequently inBalancing.olean
(this saves a bit over 2 MB).updateCell
and other functions dependent on it asnoncomputable
. The main problem withupdateCell
is how other functions, in particularglue
, get recursively inlined, which blows the size of the IR (this saves ~1 MB).simp_to_model
to prove results oninsert!
,erase!
, etc.,simpa
s are used now, e.g.simpa only [insert_eq_insert!] using isEmpty_insert h
. This mainly improves elaboration time although the olean size also goes down by ~0.3 MB.