Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change 'show' tactic to work as documented #7395

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Rob23oba
Copy link
Contributor

@Rob23oba Rob23oba commented Mar 8, 2025

This PR changes the behavior of the 'show' tactic to work as documented, i.e. unify with the first goal possible and make that the main goal.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 8, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Mar 8, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 141e519009fc74d444cb8a32b55daf3c2d192bbd --onto ca0d8226192e7c0cdcc71d6322c3226ad4f73f30. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-08 11:41:46)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b9f8a859e7f354f026de7c910e17ce29e23678f9 --onto ca0d8226192e7c0cdcc71d6322c3226ad4f73f30. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-08 13:41:28)

@nomeata
Copy link
Collaborator

nomeata commented Mar 18, 2025

Thanks! Just wants to let you know that this is a change we want. Didn't look at the changes yet, since it's still a draft. And maybe I'll leave it to @kmill to review when he gets to it.

@Rob23oba Rob23oba marked this pull request as ready for review March 27, 2025 16:29
@Rob23oba Rob23oba requested a review from kim-em as a code owner March 27, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants