-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Order/Archimedean): WithZero.mulArchimedean_iff
#22294
Conversation
with the basic instance of `WithZero.instMulArchimedean` in an earlier file Now, `#synth MulArchimedean ℤₘ₀` works
PR summary 4ac0b46a06Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer delegate
|
||
@[to_additive existing WithBot.instArchimedean] | ||
instance WithZero.instMulArchimedean (α) [OrderedCommMonoid α] [MulArchimedean α] : | ||
MulArchimedean (WithZero α) := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it kosher to additivise WithZero
to WithBot
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Because with have LinearOrderedCommGroupWithZero
and LinearOrderedAddCommGroupWith**Top**
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then can you drop the to_additive
?
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
with the basic instance of `WithZero.instMulArchimedean` in an earlier file Now, `#synth MulArchimedean ℤₘ₀` works
Pull request successfully merged into master. Build succeeded: |
WithZero.mulArchimedean_iff
WithZero.mulArchimedean_iff
with the basic instance of
WithZero.instMulArchimedean
in an earlier fileNow,
#synth MulArchimedean ℤₘ₀
works