Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Order/Archimedean): WithZero.mulArchimedean_iff #22294

Closed
wants to merge 2 commits into from

Conversation

pechersky
Copy link
Collaborator

with the basic instance of WithZero.instMulArchimedean in an earlier file
Now, #synth MulArchimedean ℤₘ₀ works


Open in Gitpod

with the basic instance of `WithZero.instMulArchimedean`
in an earlier file
Now, `#synth MulArchimedean ℤₘ₀` works
Copy link

github-actions bot commented Feb 25, 2025

PR summary 4ac0b46a06

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ OrderMonoidIso.mulArchimedean
+ WithBot.instArchimedean
+ WithZero.instMulArchimedean
+ WithZero.mulArchimedean_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 25, 2025
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate


@[to_additive existing WithBot.instArchimedean]
instance WithZero.instMulArchimedean (α) [OrderedCommMonoid α] [MulArchimedean α] :
MulArchimedean (WithZero α) := by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it kosher to additivise WithZero to WithBot?

Copy link
Collaborator Author

@pechersky pechersky Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. Because with have LinearOrderedCommGroupWithZero and LinearOrderedAddCommGroupWith**Top**.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then can you drop the to_additive?

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@pechersky pechersky added the t-order Order theory label Feb 25, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Feb 26, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 26, 2025
with the basic instance of `WithZero.instMulArchimedean` in an earlier file
Now, `#synth MulArchimedean ℤₘ₀` works
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 26, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order/Archimedean): WithZero.mulArchimedean_iff [Merged by Bors] - feat(Order/Archimedean): WithZero.mulArchimedean_iff Feb 26, 2025
@mathlib-bors mathlib-bors bot closed this Feb 26, 2025
@mathlib-bors mathlib-bors bot deleted the pechersky/with-zero-mul-archimedean branch February 26, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants