Desktop,Mobile,Cli: Fixes #10608: WebDAV synchronisation not working because of URL encoding differences

[pedr]

Fixes #10608

Summary

When using the WebDAV sync target the items data returned by the server doesn't encode URI elements of email (see test example at [email protected]), but it will encode URI folders with spaces (joplin files turns into joplin%20files).

When using the WebDAV sync target, synchronisation can fail because of the difference between the encodings of the data returned by the WebDAV API (in this case specific to the d:href property) and the relativeBaseUrl property.

Differences that I noticed:

• d:href does not encode @ but relativeBaseUrl does
• relativeBaseUrl does not encode whitespace while d:href does

I think the best solution for this would be to fix this encoding difference before it reaches the hrefToRelativePath_ function (where this PR is fixing the issue) but since it is near the feature freeze I thought that the simplesest solution would be better.

Testing

I added automated tests to the hrefToRelativePath_ function on file-api-driver-webdav.test.ts.

To create the tests I made some real world testing described bellow:

1 - Created a Joplin folder on my base WebDAV server
2 - Added WebDav as my sync target, my sync target URL has my [email protected] address on it
3 - Created some notebooks and notes and tried to synch
4 - Found the error reported in the issue because @ on email address is encoded to %40 on relativeBaseUrl value, but the d:href property with the relative path to the file doesn't encode it

Other test case:

1 - Created a joplin files folder on my base WebDAV server
2 - Added WebDav as my sync target, my sync target URL has my [email protected] address on it
3 - Created some notebooks and notes and tried to synch
4 - Now I found that d:href encodes whites spaces while relativeBaseUrl does not

[laurent22]

Looks good, thanks Pedro