feat: Option to use gzip to compress event #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
abarker-launchdarkly
force-pushed
the
abarker/sdk-826/gzip-event-compression
branch
from
a0145e6 to
6ec484d
Compare
| * Gzip compress the post body only if the underlying SDK framework supports it | ||
| * and the config option enableEventCompression is set to true. | ||
| */ | ||
| compressBodyIfPossible?: boolean; |
There was a problem hiding this comment.
I recommend against mentioning the config option here. This layer shouldn't know about the config option as the platform/Requests interface may be used in other cases in the future.
| tlsOptions?: LDTLSOptions, | ||
| proxyOptions?: LDProxyOptions, | ||
| logger?: LDLogger, | ||
| enableEventCompression?: boolean, |
There was a problem hiding this comment.
In which cases is this true and in which is it not set / false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Describe the solution you've provided
LDConfig option
enableEventCompressionwas added for js-server-sdk-common and NodeRequests was modified to support gzip compression of POST bodies if this option is enabled.