Fixed animation on Welcome page and used Tailwind 3 compatible classes #91
+48
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great @Bosphoramus. Hopefully, we can get Tailwind V4 out soon when ShadCN vue is compatible with v4, but for now, this makes the welcome page look identical 😊 Appreciate it! |
|
@tnylea I just happened to check https://github.com/unovue/shadcn-vue repo and it seems like they are tagging a 2.0 release right now 😄 |
|
Ohh thats super nice @tnylea! If you want i could do a PR to update to shadcn/vue 2.0 (the version that just came out) and Tailwind 4 I can also adjust the border radius CSS var, they are different between the React and Vue starter kits |
|
Looks like we should just update this for TW4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I fixed the animation on the Welcome page and updated everything to work with Tailwind CSS v3, right now its the version the Vue starter kit uses, because shadcn/vue does not support Tailwind 4 yet. I built a custom variant so that when you use something like starting:opacity-0, it now generates CSS that nests the rule inside an @starting-style block—just like the native at-rule is meant to work. This is why the initial animation was broken.
Please take a look and let me know what you think.