Capture job dispatch duration #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
reviewed
Feb 18, 2025
| @@ -40,7 +40,6 @@ public function __invoke(MessageSending|MessageSent $event): void | |||
|
|
|||
| if ($event instanceof MessageSending) { | |||
| $this->startTime = $now; | |||
| $this->duration = null; | |||
There was a problem hiding this comment.
💡 With this change in place, $duration doesn't need to be a class level property now and can be inlined instead. Think that applies to all of these.
There was a problem hiding this comment.
Ahhh, you are right! Now I remember why we have it for CacheEventSensor: We want to reuse the same duration when reading/writing multiple keys.
timacdonald
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR captures the job dispatch duration by listening to the
JobQueueingandJobQueuedevents and calculating the difference between their timestamps.