Skip to content

fixing layout issue where grid does not work with the UI radio element #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

tnylea
Copy link
Contributor

@tnylea tnylea commented Mar 20, 2025

This issue was brought up in the FluxUI repo: livewire/flux#1320,

We have added the:

[data-flux-field] {
    @apply grid gap-2;
}

to input fields in flux so that way the login/register forms are more consistent with the React and Vue versions; unfortunately applying grid to the Radio card causes this issue.

CleanShot 2025-03-20 at 13 19 27@2x

This update will fix that issue.

Screenshot 2025-03-20 at 1 20 07 PM

@tnylea tnylea marked this pull request as ready for review March 20, 2025 17:20
@tnylea tnylea added the Approved Approved for Merge label Mar 20, 2025
@tnylea tnylea requested a review from taylorotwell March 20, 2025 17:22
@tnylea
Copy link
Contributor Author

tnylea commented Mar 20, 2025

@taylorotwell This one is good to go when you get a sec.

Thanks!

@taylorotwell taylorotwell merged commit d1edb79 into main Apr 1, 2025
2 checks passed
@taylorotwell taylorotwell deleted the fixingFluxLayoutIssue branch April 1, 2025 15:17
vanm pushed a commit to vanm/livewire-starter-kit that referenced this pull request Apr 1, 2025
@lucasjose501
Copy link
Contributor

I believe this also happens with checkbox. I changed it to [data-flux-field]:not(ui-radio, ui-checkbox) to handle both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved for Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants