Absorb the extracttextplugin

languy · Sep 9, 2016 · ab3834d · ab3834d
1 parent 48a0896
commit ab3834d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/jupyterlab/plugin.js b/jupyterlab/plugin.js
@@ -2,7 +2,7 @@
 // Distributed under the terms of the Modified BSD License.
 
 var path = require('path');
-
+var ExtractTextPlugin = require('extract-text-webpack-plugin');
 
 /**
  * A WebPack plugin that generates custom bundles that use version and
@@ -14,12 +14,21 @@ function JupyterLabPlugin(options) {
 }
 
 
+/**
+ * The css loader that should be used with the plugin.
+ */
+JupyterLabPlugin.cssLoader = ExtractTextPlugin.extract("style-loader", "css-loader", { publicPath: './' });
+
+
 /**
  * Plugin installation, called by WebPack.
  *
  * @param compiler - The WebPack compiler object.
  */
 JupyterLabPlugin.prototype.apply = function(compiler) {
+  // Run the extract text plugin.
+  compiler.apply(new ExtractTextPlugin('[name].css'));
+
   var pluginName = this.name;
   var publicPath = compiler.options.output.publicPath;
   if (!publicPath) {

diff --git a/jupyterlab/webpack.config.js b/jupyterlab/webpack.config.js
@@ -5,18 +5,13 @@
 // See https://github.com/webpack/css-loader/issues/144
 require('es6-promise').polyfill();
 
-var ExtractTextPlugin = require('extract-text-webpack-plugin');
 var JupyterLabPlugin = require('./plugin');
 
 console.log('Generating bundles...');
 
 
 var LOADERS = [
-  { test: /\.css$/,
-    loader: ExtractTextPlugin.extract("style-loader", "css-loader", {
-      publicPath: './'
-    })
-  },
+  { test: /\.css$/, loader: JupyterLabPlugin.cssLoader },
   { test: /\.json$/, loader: 'json-loader' },
   { test: /\.html$/, loader: 'file-loader' },
   // jquery-ui loads some images
@@ -37,7 +32,7 @@ module.exports = [{
   output: {
     path: __dirname + '/build',
     filename: '[name].bundle.js',
-    publicPath: './lab/'
+    publicPath: 'lab/'
   },
   node: {
     fs: 'empty',
@@ -49,7 +44,6 @@ module.exports = [{
     loaders: LOADERS
   },
   plugins: [
-    new ExtractTextPlugin('[name].css'),
     new JupyterLabPlugin()
   ],
 },
@@ -77,7 +71,7 @@ module.exports = [{
   output: {
     path: __dirname + '/build',
     filename: '[name].bundle.js',
-    publicPath: './lab/'
+    publicPath: 'lab/'
   },
   node: {
     fs: 'empty'
@@ -89,7 +83,6 @@ module.exports = [{
     loaders: LOADERS
   },
   plugins: [
-    new ExtractTextPlugin('[name].css'),
     new JupyterLabPlugin()
   ],
 }