feat: Add loading state and skeleton UI for FlowPage sidebar #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
deon-sanchez
changed the title
mrunal2021
approved these changes
Feb 20, 2025
ogabrielluiz
changed the title
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
mfortman11
approved these changes
Feb 21, 2025
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
ogabrielluiz
added
lgtm
tianzhipeng-git
pushed a commit
to tianzhipeng-git/langflow
that referenced
this pull request
Feb 22, 2025
…w-ai#6738) * feat: Add loading state and skeleton UI for FlowPage sidebar * fix: Improve UI components with minor styling and z-index adjustments * refactor: Simplify SkeletonGroup component and update FlowPage sidebar loading state * refactor: Adjust SkeletonGroup rendering and FlowPage sidebar styling * refactor: Remove z-index from PageComponent loading state * refactor: Update FlowPage sidebar skeleton height class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the
FlowPagecomponent and its subcomponents to improve the loading state handling and user interface. The most important changes include adding a loading skeleton, refactoring components to accept a loading state, and updating theFlowPageto manage and pass down this state.Enhancements to Loading State and UI:
src/frontend/src/components/ui/skeletonGroup.tsx: Added a newSkeletonGroupcomponent to display loading skeletons.src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx: Updated thePagecomponent to accept asetIsLoadingfunction prop and use it to manage the loading state. [1] [2]src/frontend/src/pages/FlowPage/components/flowSidebarComponent/components/sidebarFooterButtons/index.tsx: Modified theSidebarMenuButtonscomponent to accept anisLoadingprop and disable buttons when loading. [1] [2]Refactoring for Loading State:
src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx: Updated theFlowSidebarComponentto accept anisLoadingprop and display theSkeletonGroupwhen loading. [1] [2] [3] [4] [5]src/frontend/src/pages/FlowPage/index.tsx: Added a loading state to theFlowPagecomponent and passed it down toFlowSidebarComponentandPagecomponents. [1] [2] [3]BUG (clicking bundles and categories will break the app)
FIX (hides all clickable items in sidebar)