Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: fix AttributeError when creating LanceDB vectorstore #30127

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

metadaddy
Copy link
Contributor

Description:

This PR adds a call to guard_import() to fix an AttributeError raised when creating LanceDB vectorstore instance with an existing LanceDB table.

Issue:

This PR fixes issue #30124.

Dependencies:

No additional dependencies.

Twitter handle:

@metadaddy, but I spend more time at @metadaddy.net these days.

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 11:00pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 5, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 5, 2025
@ccurme ccurme enabled auto-merge (squash) March 5, 2025 23:00
@ccurme ccurme merged commit b3dc66f into langchain-ai:master Mar 5, 2025
19 checks passed
@metadaddy metadaddy deleted the fix-lancedb-attribute-error branch March 5, 2025 23:40
@metadaddy
Copy link
Contributor Author

Thanks for the speedy service, @ccurme 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants