Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade Lance to v0.24.0-beta.3 #2186

Closed

Conversation

wjones127
Copy link
Contributor

@github-actions github-actions bot added the enhancement New feature or request label Mar 6, 2025
@wjones127 wjones127 marked this pull request as ready for review March 6, 2025 19:24
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we handle the pylance version in pyproject.toml now? Since we are mostly split from pylance we probably don't need to keep them in lockstep. Should we? Or should we just bump on major changes?

@github-actions github-actions bot added the Python Python SDK label Mar 7, 2025
@wjones127
Copy link
Contributor Author

How should we handle the pylance version in pyproject.toml now? Since we are mostly split from pylance we probably don't need to keep them in lockstep. Should we? Or should we just bump on major changes?

Let's loosen to a simple >= pin. We are pretty decoupled, so unless we have a serious breaking change in the table format, I don't think we need to upgrade the pin.

@wjones127
Copy link
Contributor Author

@BubbleCal I think your changes in lancedb/lance#3437 caused this test to break:

https://github.com/lancedb/lancedb/actions/runs/13725130550/job/38389636041?pr=2186#step:7:882

Is this expected? Or does this sound like a bug?

@wjones127 wjones127 closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants