Skip to content

fix(core): fix criterion benchmark #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

fix(core): fix criterion benchmark #2439

merged 2 commits into from
Apr 11, 2025

Conversation

iovoid
Copy link
Contributor

@iovoid iovoid commented Apr 10, 2025

Motivation

On #2419 the criterion benchmark was broken printing extra lines, which causes the parser to fai.

Description

Replaces println!() with info!() on the non-user-interactive path.

@iovoid iovoid requested a review from a team as a code owner April 10, 2025 16:47
Copy link

Lines of code report

Total lines added: 416
Total lines removed: 0
Total lines changed: 416

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/cmd/ethrex_l2/src/cli.rs           | 50    | +3   |
+-------------------------------------------+-------+------+
| ethrex/cmd/ethrex_l2/src/commands/mod.rs  | 7     | +1   |
+-------------------------------------------+-------+------+
| ethrex/cmd/ethrex_l2/src/commands/test.rs | 412   | +412 |
+-------------------------------------------+-------+------+

@mpaulucci mpaulucci changed the title fix(core): fix criterion bencmark fix(core): fix criterion benchmark Apr 11, 2025
@fkrause98 fkrause98 added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit ebffcf9 Apr 11, 2025
22 of 23 checks passed
@fkrause98 fkrause98 deleted the fix/removedb branch April 11, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants