Skip to content

feat(l2): make deposits on l2 work as expected #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 212 commits into from
Apr 15, 2025
Merged

feat(l2): make deposits on l2 work as expected #2332

merged 212 commits into from
Apr 15, 2025

Conversation

tomip01
Copy link
Contributor

@tomip01 tomip01 commented Mar 27, 2025 •
edited
Loading

Motivation

In this PR we refactor some of the code and add functionality to work as expected. Remove the txs magic hack data #2147

Description

  • Add a recipient field to the privileged transactions.
  • Deposit the value to the recipient instead of the to address.
  • Add functionality to call a contract and make a deposit in the same privileged transaction.
  • Remove the signing of the privileged transactions.
  • Remove the checking of the nonce and balance when making the deposit, here we mint the tokens.
  • Add new hook in the L2 to address this new features for the Privileged Transactions.

Closes #2147

fborello-lambda and others added 30 commits March 14, 2025 18:46
feat: read address of each verifier contract
a9dd3c5
refactor: send_tx if we have the needed_proof_type
7fa2bad
refactor: create sp1's client once
f4131f2
Merge branch 'main' into l2/prover_dont_wait_for_proofs
ab393a2
fix: compilation errors
d39d2ab
fix: Makefile feature flag
3dd7ebb
fix: calldata and Cargo.lock
3d0a1f7
refactor/fix: unique and static SP1's Client
2f423fd 
fix some issues when using with CUDA
chore: fix lint
8acd84d
refactor: remove exec_proof in OnChainProposer
34b1124
refactor: do not save exec proofs
6d3c638
refactor: use consts for the signatures
265c7f3
fix: lint
e0cab9a
fix: lint
4a94a10
@fborello-lambda
Merge branch 'main' into l2/prover_dont_wait_for_proofs
2d3dbaf
@tomip01
remove signing
0367399
@tomip01
better panic
7c469dc
@tomip01
use l2 address
f5f51db
@tomip01
add new with hooks
5dd583f
@tomip01
remove fee cost
b8fd34b
@tomip01
fix address
0cec893
@tomip01
correct from tx, missing test failure
9667bbd
@tomip01
remove fees and correct from
e1f4e5e
@tomip01
fix lint
975081e
@tomip01
remove dummy tx hash
72b5ab5
@tomip01
some testing
5822c98
@xqft
reintroduce exec proof
dd7db43
@xqft
add test-tmux as integration test
b2472b1
@xqft
modify integration test, add build-prover
8170f1a
@xqft
add toolchain install to job
07843f8
@jrchatruc jrchatruc force-pushed the l2/deposits-from-l1 branch from 1088cfc to 08fd493 Compare April 14, 2025 14:04
ManuelBilbao
ManuelBilbao reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@ManuelBilbao ManuelBilbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit comments

samoht9277 and others added 5 commits April 14, 2025 16:25
@samoht9277 @jrchatruc
Ci selfhosted (#2458)
c5daef2 
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #issue_number

---------

Co-authored-by: Javier Chatruc <[email protected]>
@jrchatruc
Remove dbg!
7252959
@jrchatruc
Remove commented out dependency
2ec54b6
@jrchatruc
Improve code with suggestion
52b638a
@jrchatruc
Another code improvement
28c8c05
ManuelBilbao and others added 8 commits April 14, 2025 18:10
@ManuelBilbao
Remove docker config examples
0d24a98
@ManuelBilbao
Remove unwraps
639b737
@samoht9277
Added chown for CI. (#2465)
d1a1b6b 
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #issue_number
@jrchatruc
Try out CI with GPU
b1f33a1
@jrchatruc
Fix get_block_hash implementation for rpcdb
c146594
@jrchatruc
Merge branch 'main' into l2/deposits-from-l1
3259a47
@jrchatruc
Fix integration test CI
2bf7852
@jrchatruc
Make sp1 integration test run only on merges to main
c4c459c
@jrchatruc jrchatruc enabled auto-merge April 15, 2025 17:57
@jrchatruc jrchatruc mentioned this pull request Apr 15, 2025
Closed
@jrchatruc jrchatruc added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 72b8edc Apr 15, 2025
54 checks passed
@jrchatruc jrchatruc deleted the l2/deposits-from-l1 branch April 15, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelBilbao ManuelBilbao ManuelBilbao approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@tomip01 tomip01

Labels
L2 Rollup client
Projects
ethrex_l2
Status: Done
Milestone
No milestone
6 participants
@tomip01 @ManuelBilbao @jrchatruc @fborello-lambda @xqft @samoht9277