Update translations from Weblate #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
8668125 to
c33b03c
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
81ea8e1 to
c201ce8
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
c201ce8 to
dea3b83
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
9ea4a6b to
2a2ff87
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
2a2ff87 to
55f30ff
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
55f30ff to
2cd3f29
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
2cd3f29 to
323e644
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
323e644 to
47dba8f
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
47dba8f to
9c07851
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
9c07851 to
9fd7387
Compare
Flutter PR flutter/flutter#165596 (wiring up MenuAnchor-related widgets to SemanticsRole) breaks this test; fix it by adding the needed Semantics wrappers. Co-authored-by: Chris Bobbe <[email protected]>
Greg found that this is a side effect of the Flutter upgrade in PR zulip#1426: zulip#1444 (comment) > And indeed, `git log -G flutter_lldbinit` in the Flutter tree > finds this from earlier this month, 2025-03-06: > flutter/flutter@eb07c5123 Committing it here, after building for iOS, which we forgot to do when preparing that PR.
These are needed because zulip#1426 didn't include the `pod` step of `tools/upgrade`. Done by building for iOS, then (when I remembered that macOS/Podfile.lock needs updating too) `tools/upgrade pod`.
This example demonstrates a bug we'll shortly fix: an overflowing sliver getting painted before the sliver it's meant to overflow onto.
This lets these tests stop caring which specific ScrollView subclass the implementation of MessageList uses.
This lets us control the paint order between the slivers, so that the top sliver is able to overflow over the bottom sliver when a sticky header calls for that. I've sent a PR upstream to add the same feature to CustomScrollView itself: flutter/flutter#164818 That PR has been delayed by infra issues in Google testing, though. So doing this in our tree lets us move ahead without waiting. (I actually wrote this version first, then adapted it to produce the upstream PR. So landing this version isn't significant extra work.)
…and doc By letting us control the paint order between slivers, this fixes all the skipped tests in this test file.
This changes the paint order of these slivers. Right now that has no observable effect, because the second sliver has zero height and paints nothing. In the future when we put the messages in back-to-back slivers, this is the paint order we'll need so that the top sliver can have a sticky header overflow properly over the bottom sliver.
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
9fd7387 to
77a4794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action