Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-404): show or hide model folder related info #3049

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 20, 2025

resolves (FR-404)
related PR: lablup/backend.ai#3503

Adds a configuration flag enableModelFolders to control the visibility of model folder features in the UI. When disabled, this removes the "Model" option from folder creation and hides the Models tab in the folder list view.

Checklist:

  • Documentation
  • Minium required manager version: Backend.AI 23.03
  • Specific setting for review: Set enableModelFolders = false in config.toml to verify feature is hidden
  • Minimum requirements to check during review:
    • Model radio option should be hidden in folder creation dialog when disabled
    • Models tab should not appear in folder list when disabled
    • Features should be visible when enabled (default true)

@github-actions github-actions bot added the size:S 10~30 LoC label Jan 20, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 20, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.63% 401/8659
🔴 Branches
4.02% (-0% 🔻)
239/5948
🔴 Functions 2.8% 78/2788
🔴 Lines 4.56% 386/8473

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from e697ebd

Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

@agatha197 agatha197 force-pushed the feature/hide-model-folders branch from 8894192 to b27d6fa Compare February 17, 2025 06:20
@agatha197 agatha197 requested a review from lizable February 17, 2025 06:20
Copy link
Contributor Author

Done!

Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@agatha197 agatha197 force-pushed the feature/hide-model-folders branch from b27d6fa to e697ebd Compare February 18, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants