app welcome screen #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your assigned issue has nothing to do with the splash Activity, if you check the Figma there are two pages with a Welcome attached to its title. Also like I stated in the doc we are following the single activity principle which means only the MainActivity will be the existing Activity in the app while all screens will be fragment. and also you create your PR against develop not master which will require you always pull to refresh your local to avoid conflicts which is currently in this PR |
|
Oh my goodness.
…On Wed, Oct 14, 2020, 12:16 PM Chidi Loveth ***@***.***> wrote:
your assigned issue has nothing to do with the splash Activity, if you
check the sigma there are two pages with a Welcome attached to its title.
Also like I stated in the doc we are following the single activity
principle which means only the MainActivity will be the existing Activity
in the app while all screens will be fragment. and also you create your PR
against develop not master which will require you always pull to refresh
your local to avoid conflicts which is currently in this PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AODISW2GBXRNYX2USTSGPYTSKWB7PANCNFSM4SQOGSLA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to create the UI but with some challanges in the SpashScreenActivity.kt file. Please help to fix the kotlin codes. Do take a look anyways. I'll be fully available from 5pm WAT.
Love to hear your feedback.
Best Regards,
Osaitie