Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Deprecated shortcode site-searchbar #50151

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

biswajeet0192
Copy link

Description

Rmeoved the deprecated shortcode site-searchbar.

Closes: #50147

Copy link

linux-foundation-easycla bot commented Mar 19, 2025

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language labels Mar 19, 2025
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 19, 2025
Copy link

netlify bot commented Mar 19, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b436029
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67dbb935c576cc000825b7ff
😎 Deploy Preview https://deploy-preview-50151--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SayakMukhopadhyay
Copy link
Contributor

SayakMukhopadhyay commented Mar 19, 2025

@biswajeet0192 Thanks for the contribution. Please sign the CLA
You can find the steps documented here: CLA Instructions

Also do note that we would want to make the change on each translation one by one. Since the english one is already done, please reduce the scope of this PR to a single language.

Moreover, as a nitpick, please remove the extra newlines when you remove the shortcode. See

---
{{< blocks/section class="k8s-overview" >}}
as a reference.

Do note, that you don't need to close this PR, you can push the recommendations to the current branch and the PR will update.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/uk Issues or PRs related to Ukrainian language labels Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maxymvlasov, rajibmitra, tengqm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2025
@biswajeet0192 biswajeet0192 requested a review from Arhell March 20, 2025 06:50
@Aaina26
Copy link
Contributor

Aaina26 commented Mar 20, 2025

I think this file needs to be removed too. If we are removing all the instances of the shortcode. There is no point in having layouts/shortcodes/site-searchbar.html

@Aaina26
Copy link
Contributor

Aaina26 commented Mar 20, 2025

This also might be helpful to look at: https://github.com/search?q=repo%3Akubernetes%2Fwebsite%20site-searchbar&type=code

@SayakMukhopadhyay
Copy link
Contributor

SayakMukhopadhyay commented Mar 20, 2025

I think this file needs to be removed too. If we are removing all the instances of the shortcode. There is no point in having layouts/shortcodes/site-searchbar.html

Indeed, the site-searchbar shortcode can be removed once all use of the shortcode has been removed. But as mentioned earlier, it is expected to change each translation one by one in separate PRs.

There are a few other issues with this PR too, like it not being rebased properly and the CLA not being signed.

@biswajeet0192 if you need any help, feel free to drop in the k8s slack and giving me a ping.

@Aaina26
Copy link
Contributor

Aaina26 commented Mar 20, 2025

Got it! Thanks for clearing that up @SayakMukhopadhyay

@SayakMukhopadhyay
Copy link
Contributor

See #50199 which has references to individual PRs for each language.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated Shortcode site-searchbar
10 participants