-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Deprecated shortcode site-searchbar #50151
base: main
Are you sure you want to change the base?
Conversation
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@biswajeet0192 Thanks for the contribution. Please sign the CLA Also do note that we would want to make the change on each translation one by one. Since the english one is already done, please reduce the scope of this PR to a single language. Moreover, as a nitpick, please remove the extra newlines when you remove the shortcode. See website/content/en/_index.html Lines 7 to 9 in 715b7a5
Do note, that you don't need to close this PR, you can push the recommendations to the current branch and the PR will update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/easycla
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: xin.li <[email protected]>
Signed-off-by: xin.li <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this file needs to be removed too. If we are removing all the instances of the shortcode. There is no point in having |
This also might be helpful to look at: https://github.com/search?q=repo%3Akubernetes%2Fwebsite%20site-searchbar&type=code |
Indeed, the There are a few other issues with this PR too, like it not being rebased properly and the CLA not being signed. @biswajeet0192 if you need any help, feel free to drop in the k8s slack and giving me a ping. |
Got it! Thanks for clearing that up @SayakMukhopadhyay |
See #50199 which has references to individual PRs for each language. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Rmeoved the deprecated shortcode site-searchbar.
Closes: #50147