Mention the builtin clusterrole in kubelet authorization #50145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
liggitt
reviewed
Mar 19, 2025
sftim
reviewed
Mar 19, 2025
Comment on lines
122
to
124
| Enabling this gate also ensure that the builtin `system:kubelet-api-admin` ClusterRole | ||
| is updated with permissions to access all the above mentioned subresources. |
There was a problem hiding this comment.
We should caveat this that it applies to clusters using RBAC mode authz.
(Clusters not using RBAC don't have ClusterRoles).
This PR updates the description about the kubelet fine-grained API authorization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the description about the kubelet fine-grained API authorization.
According to the upstream implementation (kubernetes/kubernetes#126347), the fine-grained authorization doesn't include
nodes/spec.The previous docs didn't mention that the builtin clusterrole exists and will get updated.