Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for (EN) not appearing in docs sidebar for i18nised site #50133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SayakMukhopadhyay
Copy link
Contributor

@SayakMukhopadhyay SayakMukhopadhyay commented Mar 18, 2025

Description

The fix involves removing the SCSS which "hid" the element. Moreover, the sidebars no longer have the #m-docs HTML ID anywhere as the HTML element bearing that ID in Docsy is removed from the overriden sidebar-tree.html template.

Issue

Closes: #50132

Before -> After
image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm March 18, 2025 15:28
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2025
Copy link

netlify bot commented Mar 18, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c8bfdbc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d9b90c47b8dc0008688915
😎 Deploy Preview https://deploy-preview-50133--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SayakMukhopadhyay SayakMukhopadhyay force-pushed the docs-sidebar-i18n-indicator branch from d107c00 to c8bfdbc Compare March 18, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar in the docs pages of I18nised site don't mark the non-translated menu items with (EN)
2 participants