Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc for email_verified requirement when username contains claims.email #50128

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix doc for email_verified requirement when username contains claims.email #50128

merged 1 commit into from
Mar 18, 2025
+3 −1

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 17, 2025

follow-up to kubernetes/kubernetes#130875

/sig auth
/assign enj liggitt
/cc @benjaminapetersen

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 17, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4888dbe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d8b987b001af0008433b9d
😎 Deploy Preview https://deploy-preview-50128--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aramase aramase force-pushed the aramase/f/fix_email_verified_godoc branch from fb93e61 to 1f21808 Compare March 17, 2025 23:19
@aramase
Copy link
Member Author

aramase commented Mar 17, 2025

/hold

for kubernetes/kubernetes#130875 to be merged!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2025
@aramase aramase force-pushed the aramase/f/fix_email_verified_godoc branch from 1f21808 to 4888dbe Compare March 18, 2025 00:08
@liggitt
Copy link
Member

liggitt commented Mar 18, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 49ecd61d088c66358efcf370b5570595151b42f9

@aramase
Copy link
Member Author

aramase commented Mar 18, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2025
@Shubham82
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liggitt Once this PR has been reviewed and has the lgtm label, please assign rayandas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

As mentioned, This PR needs to be approved by the sig-docs owner.

cc @kubernetes/sig-docs-en-owners PTAL!

sftim
sftim reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7d8d910 into kubernetes:main Mar 18, 2025
6 checks passed
@aramase aramase deleted the aramase/f/fix_email_verified_godoc branch March 18, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@liggitt liggitt

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Auth
Status: Closed / Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aramase @liggitt @k8s-ci-robot @Shubham82 @sftim @enj