Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bn] Added "LinkedIn" to toml #50127

Merged
merged 1 commit into from
Mar 19, 2025
Merged

[bn] Added "LinkedIn" to toml #50127

merged 1 commit into from
Mar 19, 2025

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Mar 17, 2025

https://github.com/kubernetes/website/pull/49878/files
I used a translator, if anything please correct me

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 17, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b60ffea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d8a6d98020650008ef5b4c
😎 Deploy Preview https://deploy-preview-50127--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of community_linkedin_name parameter looks in sync with 'en' PR https://github.com/kubernetes/website/pull/49878/files

LGTM

@SayakMukhopadhyay
Copy link
Contributor

I speak Bengali and this
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59406b32424c17cb2d40de9f56ceb87ae529dd7f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitul3737

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@mitul3737
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2025
@mitul3737
Copy link
Member

@Arhell It's suggested to target kubernetes:dev-1.31-bn.1 branch everytime. Kindly let us know once you are done with that.

@Arhell
Copy link
Member Author

Arhell commented Mar 19, 2025

@Arhell It's suggested to target kubernetes:dev-1.31-bn.1 branch everytime. Kindly let us know once you are done with that.

If it's not critical I wouldn't want to do it. The change isn't big.

@mitul3737
Copy link
Member

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5788b32 into kubernetes:main Mar 19, 2025
6 checks passed
@Arhell
Copy link
Member Author

Arhell commented Mar 19, 2025

@mitul3737 thanks

@Arhell Arhell deleted the bn-add branch March 19, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mitul3737 mitul3737 mitul3737 approved these changes

@asem-hamid asem-hamid Awaiting requested review from asem-hamid

@sajibAdhi sajibAdhi Awaiting requested review from sajibAdhi

Assignees

@SayakMukhopadhyay SayakMukhopadhyay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Arhell @SayakMukhopadhyay @k8s-ci-robot @mitul3737 @dipesh-rawat