Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bn] Localization of garbage-collection.md #50117

Open
wants to merge 2 commits into
base: dev-1.31-bn.1
Choose a base branch
from
Open

[bn] Localization of garbage-collection.md #50117

wants to merge 2 commits into from

Conversation

fatimajannet
Copy link
Contributor

@fatimajannet fatimajannet commented Mar 16, 2025 •
edited
Loading

I've localized the garbage-collection.md file in Bangla.
Related issue : #47747

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mitul3737 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Mar 16, 2025
@k8s-ci-robot k8s-ci-robot added language/bn Issues or PRs related to Bengali language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2025
dipesh-rawat
dipesh-rawat reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the build preview failed with the following error (link here):

Warning

2:56:29 PM: Error: error building site: assemble: "/opt/build/repo/content/bn/docs/concepts/architecture/garbage-collection.md:28:1": failed to extract shortcode: shortcode "note" must be closed or self-closed
2:56:29 PM: make: *** [Makefile:43: deploy-preview] Error 1

I've added the suggestion in the line below - please take a look and see if it resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@asem-hamid asem-hamid Awaiting requested review from asem-hamid

@Imtiaz1234 Imtiaz1234 Awaiting requested review from Imtiaz1234

Assignees
No one assigned
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatimajannet @k8s-ci-robot @dipesh-rawat