-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hi] update: docs/home/_index.md #50115
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankur0904 Thanks so much for your help with the Hindi localization!
It seems the current changes might need a bit of adjustment.
content/hi/docs/home/_index.md
Outdated
button: "उपलब्ध संस्करण देखें" | ||
button_path: "/docs/home/supported-doc-versions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button
and button_path
appear to be placed incorrectly in the front matter. You can refer to the English upstream file (here) for guidance, as I believe these should be positioned in block at the end of the file (shown below)
website/content/hi/docs/home/_index.md
Lines 62 to 64 in a60151e
- name: about | |
title: प्रलेखन के बारे में | |
description: इस वेबसाइट में कुबेरनेट्स के वर्तमान और पिछले 4 संस्करणों के लिए प्रलेखन हैं। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you've committed the changes, you can also verify if they are rendering as expected by previewing the link to check if everything looks correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, if possible, could you arrange the 'cards' section to follow the same order as the English version (here)? This would ensure consistency between the English (here) and Hindi (here) docs home pages. If you prefer, feel free to address this in a separate PR. Thanks again!
@dipesh-rawat |
menu
sectionhttps://kubernetes.slack.com/archives/C0191RDKHU1/p1738917120280889
cc: @divya-mohan0209