Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] update: docs/home/_index.md #50115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ankur0904
Copy link
Contributor

  • update the menu section
  • add a missing button "See available versions"

https://kubernetes.slack.com/archives/C0191RDKHU1/p1738917120280889

cc: @divya-mohan0209

Verified

This commit was signed with the committer’s verified signature.
sbordet Simone Bordet
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 16, 2025
@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2025
Copy link

netlify bot commented Mar 16, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 69df2e4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d853cc07ae54000815b9ef
😎 Deploy Preview https://deploy-preview-50115--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankur0904 Thanks so much for your help with the Hindi localization!
It seems the current changes might need a bit of adjustment.

Comment on lines 17 to 18
button: "उपलब्ध संस्करण देखें"
button_path: "/docs/home/supported-doc-versions"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button and button_path appear to be placed incorrectly in the front matter. You can refer to the English upstream file (here) for guidance, as I believe these should be positioned in block at the end of the file (shown below)

- name: about
title: प्रलेखन के बारे में
description: इस वेबसाइट में कुबेरनेट्स के वर्तमान और पिछले 4 संस्करणों के लिए प्रलेखन हैं।

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've committed the changes, you can also verify if they are rendering as expected by previewing the link to check if everything looks correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, if possible, could you arrange the 'cards' section to follow the same order as the English version (here)? This would ensure consistency between the English (here) and Hindi (here) docs home pages. If you prefer, feel free to address this in a separate PR. Thanks again!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2025
@ankur0904
Copy link
Contributor Author

@dipesh-rawat
Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants