Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Update concepts/workloads/pods/ephemeral-containers to follow the upstream #50112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kakts
Copy link
Member

@kakts kakts commented Mar 16, 2025

Description

Updated https://kubernetes.io/ja/docs/concepts/workloads/pods/ephemeral-containers/ to the latest version.

Issue

Closes: #50106

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/localization General issues or PRs related to localization labels Mar 16, 2025
@k8s-ci-robot k8s-ci-robot requested review from nasa9084 and t-inu March 16, 2025 12:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inductor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 16, 2025
Copy link

netlify bot commented Mar 16, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ada599f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d833093ccc3f0008fffc0f
😎 Deploy Preview https://deploy-preview-50112--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューをしました。
あと、4行目のweight: 80は、最新ではweight: 60になっていましたので、そこも更新をお願いしたいです。

エフェメラルコンテナをPodに追加した後は、通常のコンテナのようにエフェメラルコンテナを変更または削除することはできません。

{{< note >}}
エフェメラルコンテナは [static Pod](/docs/tasks/configure-pod-container/static-pod/)ではサポートされていません。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
エフェメラルコンテナは [static Pod](/docs/tasks/configure-pod-container/static-pod/)ではサポートされていません。
エフェメラルコンテナは[static Pod](/ja/docs/tasks/configure-pod-container/static-pod/)ではサポートされていません。

空白を詰めて「、」にしました。
それと、日本語ページがありますね。

@@ -42,106 +42,6 @@ weight: 80

エフェメラルコンテナを利用する場合には、他のコンテナ内のプロセスにアクセスできるように、[プロセス名前空間の共有](/ja/docs/tasks/configure-pod-container/share-process-namespace/)を有効にすると便利です。

エフェメラルコンテナを利用してトラブルシューティングを行う例については、[デバッグ用のエフェメラルコンテナを使用してデバッグする](/ja/docs/tasks/debug/debug-application/debug-running-pod/#ephemeral-container)を参照してください。
## What's next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## What's next
## {{% heading "whatsnext" %}}

この表記にしておけば、日本語のページでは「次の項目」に置換されると思います。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちら知らなかったです!ありがとうございます!

```shell
kubectl attach -it example-pod -c debugger
```
エフェメラルコンテナを利用してトラブルシューティングを行う例については、[デバッグ用のエフェメラルコンテナを使用してデバッグする](/ja/docs/tasks/debug/debug-application/debug-running-pod/#ephemeral-container)を参照してください。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
エフェメラルコンテナを利用してトラブルシューティングを行う例については、[デバッグ用のエフェメラルコンテナを使用してデバッグする](/ja/docs/tasks/debug/debug-application/debug-running-pod/#ephemeral-container)を参照してください
* [デバッグ用のエフェメラルコンテナを使用してデバッグする](/ja/docs/tasks/debug/debug-application/debug-running-pod/#ephemeral-container)方法について学ぶ

書かれているのはこれだけでしたので、合わせました。
また、箇条書きの指定を加えました。

@kakts
Copy link
Member Author

kakts commented Mar 17, 2025

@t-inu Thank you for reviewing. I fixed them.

Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c56df63c6386108a7b1051c8f08265883d97c462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] Update docs/concepts/workloads/pods/ephemeral-containers.md to the latest version in Japanese
3 participants