Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main branch into dev-1.33 #50098

Open
wants to merge 41 commits into
base: dev-1.33
Choose a base branch
from

Conversation

michellengnx
Copy link
Contributor

This PR syncs the dev-1.33 branch with the main branch to keep the dev-1.33 branch up to date.

cc: @ArvindParekh @cloudmelon @rayandas @hacktivist123 @sreeram-venkitesh @Urvashi0109

Arhell and others added 30 commits December 8, 2024 01:15
* Update the card front-matter on pages tasks/tools/_index.md and
  tasks/tools/install-kubectl-linux.md
* Reformat tasks/tools/_index.md page to break lines at the 80 character mark.
Co-authored-by: Sandipan Panda <[email protected]>
The moved documentation describes a task, so move it to the
documentation section that describes tasks.
Tell `nc` to report open ports instead of initiating a connection by
using the `-z` flag, and report connection failure after a timeout of 2
seconds.
Improve connectivity check from thr control plane node to the load balancer
…-docs-contribute-style-page-content-types.md

[pl] docs/contribute/style/page-content-types.md
[zh] remove extra space in pod tag
…task

Move CSR for client certificate to tasks section
Update the check for open port in install-kubeadm.md
[zh] sync node-shutdown images crictl
[zh] Sync certificate-signing-requests.md
[zh-cn] Fix a typo in the network-policies page
…playground

add new playground to kubernetes documentation
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2025
Copy link

netlify bot commented Mar 14, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5dead83
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d47505baeed60008f51f7b
😎 Deploy Preview https://deploy-preview-50098--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michellengnx Looks like the target branch is set to main, but wouldn’t it be more appropriate to set it to dev-1.33? This change would better align with the intended sync objective. Could you please update the target branch?

@michellengnx michellengnx changed the base branch from main to dev-1.33 March 15, 2025 02:51
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2025
@michellengnx
Copy link
Contributor Author

@michellengnx Looks like the target branch is set to main, but wouldn’t it be more appropriate to set it to dev-1.33? This change would better align with the intended sync objective. Could you please update the target branch?

@dipesh-rawat fixed! thanks for letting me know.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 608083064a19ef4bc894059aa925af3e44e4ebd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.