Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Minor update for the Japanese localization style guide #49695

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ja] Minor update for the Japanese localization style guide #49695

wants to merge 2 commits into from

Conversation

youmeim
Copy link
Contributor

@youmeim youmeim commented Feb 9, 2025

Description

Update content/ja/docs/contribute/localization.md.

This PR contains two small modification in the Japanese localization style guide. These changes are based on discussions in #49285 and here.

Issue

Closes: #49285

prow >

/area localization
/language ja

@youmeim
[ja] Update localization style guide.
e351592 
* add a sample translation flow for miscellaneous k terminology
* add a rule for a colon : character
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inductor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2025
@youmeim
Copy link
Contributor Author

youmeim commented Feb 9, 2025

レビューありがとうございます。
コロンの件も含めておりますので、確認頂ければ幸いです。

JFYI: #49285 での改善提案の内容と異なる点は、語尾(指示口調を排除)のみです。

イシューに関してもご意見ありましたら是非、と思います。

@netlify Netlify
Copy link

netlify bot commented Feb 9, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e459e5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67b79d48dd91620008fcc9d8
😎 Deploy Preview https://deploy-preview-49695--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@youmeim
Copy link
Contributor Author

youmeim commented Feb 9, 2025 •
edited
Loading

preview: https://deploy-preview-49695--kubernetes-io-main-staging.netlify.app/ja/docs/contribute/localization/

マージに先だって、標準化用語集の翻訳をひととおり完了させておいた方がよさそうですね。

from #49285
標準化用語集( https://kubernetes.io/ja/docs/reference/glossary/?all=true ) に記載の用語は、その表現に準拠させる
ただしその場合は、 https://kubernetes.io/ja/docs/reference/glossary/?all=true の翻訳を完了させることがガイドライン更新の必要条件になると思います

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2025
@Okabe-Junya
Copy link
Member

/cc

Okabe-Junya
Okabe-Junya reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

精力的にありがとうございます！
数点コメントさせていただいたので、ご確認ください！

content/ja/docs/contribute/localization.md Outdated
Comment on lines 88 to 90
1. [APIリソースの一覧](https://kubernetes.io/docs/reference/kubernetes-api/)または[標準化用語集](https://kubernetes.io/ja/docs/reference/glossary/?fundamental=true)に対象の用語が掲載されている場合は、掲載されている用語で表記します。
2. その他のKubernetes用語については、固有名詞と判断できるものは原則アルファベットで表記します。
3. 新しく用語を日本語として翻訳する際は、レビュアーやそのコンポーネントを熟知した人に意見を聞いて下さい。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このページでは、列挙の中は「だ・である」、それ以外は「です・ます」体を用いているので、統一して頂きたいです

Copy link
Contributor Author

@youmeim youmeim Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このページでは、列挙の中は「だ・である」、それ以外は「です・ます」体を用いているので、統一して頂きたいです

そういえば、前回のスタイルガイド変更時の議論で言及してたような...
直します。

kubernetes-docs-ja チームは、あなたのコメントを歓迎します！

読んでくれた貢献者に対する敬意を表して、この部分だけはあえて原則を破って(丁寧語にして)みては？

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@youmeim
Copy link
Contributor Author

youmeim commented Feb 18, 2025

レビューありがとうございます...

しばらく作業＆反応できておらずすみません
ＰＣ不調にてWeb経由でPR対応させて頂くことになりそうです。
今夜いちど見ます

@Okabe-Junya
Copy link
Member

Okabe-Junya commented Feb 18, 2025 •
edited
Loading

OSSで善意的に取り組んでいただいているものなので、特段急いでいただかなくても大丈夫です🙆‍♂️
お時間の取れる際に適宜進めていただければ嬉しいです

youmeim
youmeim commented Feb 20, 2025
View reviewed changes
Copy link
Contributor Author

@youmeim youmeim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply changes based on the first review (寝起きにつき、指が思いもよらぬ文字列を入力したようです)

content/ja/docs/contribute/localization.md Outdated
Comment on lines 88 to 90
1. [APIリソースの一覧](https://kubernetes.io/docs/reference/kubernetes-api/)または[標準化用語集](https://kubernetes.io/ja/docs/reference/glossary/?fundamental=true)に対象の用語が掲載されている場合は、掲載されている用語で表記します。
2. その他のKubernetes用語については、固有名詞と判断できるものは原則アルファベットで表記します。
3. 新しく用語を日本語として翻訳する際は、レビュアーやそのコンポーネントを熟知した人に意見を聞いて下さい。
Copy link
Contributor Author

@youmeim youmeim Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このページでは、列挙の中は「だ・である」、それ以外は「です・ます」体を用いているので、統一して頂きたいです

そういえば、前回のスタイルガイド変更時の議論で言及してたような...
直します。

kubernetes-docs-ja チームは、あなたのコメントを歓迎します！

読んでくれた貢献者に対する敬意を表して、この部分だけはあえて原則を破って(丁寧語にして)みては？

Okabe-Junya
Okabe-Junya requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、conflictしているのでその解消だけお願いします

@Okabe-Junya
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 21, 2025
@Okabe-Junya
Copy link
Member

/assign nasa9084
for approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okabe-Junya Okabe-Junya Okabe-Junya requested changes

@kakts kakts Awaiting requested review from kakts

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@nasa9084 nasa9084

Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/ja Issues or PRs related to Japanese language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Clarify the localization process for kubernetes-specific terminologies (especially for boundary cases)
4 participants
@youmeim @k8s-ci-robot @Okabe-Junya @nasa9084